Bastelstube
/
Tims-Chat
mirror of https://github.com/wbbaddons/Tims-Chat.git
1
0
Fork 0
Code Issues Releases Wiki Activity

Add proper return types to all MessageTypes

This commit is contained in:
Tim Düsterhus 2022-03-04 19:27:17 +01:00
parent 9119b4ab22
commit 164e1ab1c6
Signed by: TimWolla
GPG Key ID: 8FF75566094168AF
21 changed files with 70 additions and 70 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
files/lib/system/message/type/AttachmentMessageType.class.php
View File

@ -42,7 +42,7 @@ final class AttachmentMessageType implements IMessageType, IDeletableMessageType
/**
* @inheritDoc
*/
public function getJavaScriptModuleName()
public function getJavaScriptModuleName(): string
{
return 'Bastelstu.be/Chat/MessageType/Plain';
}
@ -50,13 +50,13 @@ final class AttachmentMessageType implements IMessageType, IDeletableMessageType
/**
* @inheritDoc
*/
public function canDelete(Message $message, ?UserProfile $user = null)
public function canDelete(Message $message, ?UserProfile $user = null): bool
{
if ($user === null) {
$user = new UserProfile(WCF::getUser());
}
return $user->getPermission('mod.chat.canDelete');
return !!$user->getPermission('mod.chat.canDelete');
}
/**

8
files/lib/system/message/type/AwayMessageType.class.php
View File

@ -31,7 +31,7 @@ final class AwayMessageType implements IMessageType
/**
* @inheritDoc
*/
public function getJavaScriptModuleName()
public function getJavaScriptModuleName(): string
{
return 'Bastelstu.be/Chat/MessageType/Away';
}
@ -39,7 +39,7 @@ final class AwayMessageType implements IMessageType
/**
* @inheritDoc
*/
public function canSee(Message $message, Room $room, ?UserProfile $user = null)
public function canSee(Message $message, Room $room, ?UserProfile $user = null): bool
{
if ($user === null) {
$user = new UserProfile(WCF::getUser());
@ -63,7 +63,7 @@ final class AwayMessageType implements IMessageType
/**
* @inheritDoc
*/
public function canSeeInLog(Message $message, Room $room, ?UserProfile $user = null)
public function canSeeInLog(Message $message, Room $room, ?UserProfile $user = null): bool
{
if ($user === null) {
$user = new UserProfile(WCF::getUser());
@ -87,7 +87,7 @@ final class AwayMessageType implements IMessageType
/**
* @inheritDoc
*/
public function supportsFastSelect()
public function supportsFastSelect(): bool
{
return false;
}

8
files/lib/system/message/type/BackMessageType.class.php
View File

@ -31,7 +31,7 @@ final class BackMessageType implements IMessageType
/**
* @inheritDoc
*/
public function getJavaScriptModuleName()
public function getJavaScriptModuleName(): string
{
return 'Bastelstu.be/Chat/MessageType/Back';
}
@ -39,7 +39,7 @@ final class BackMessageType implements IMessageType
/**
* @inheritDoc
*/
public function canSee(Message $message, Room $room, ?UserProfile $user = null)
public function canSee(Message $message, Room $room, ?UserProfile $user = null): bool
{
if ($user === null) {
$user = new UserProfile(WCF::getUser());
@ -63,7 +63,7 @@ final class BackMessageType implements IMessageType
/**
* @inheritDoc
*/
public function canSeeInLog(Message $message, Room $room, ?UserProfile $user = null)
public function canSeeInLog(Message $message, Room $room, ?UserProfile $user = null): bool
{
if ($user === null) {
$user = new UserProfile(WCF::getUser());
@ -87,7 +87,7 @@ final class BackMessageType implements IMessageType
/**
* @inheritDoc
*/
public function supportsFastSelect()
public function supportsFastSelect(): bool
{
return false;
}

12
files/lib/system/message/type/BroadcastMessageType.class.php
View File

@ -39,7 +39,7 @@ final class BroadcastMessageType implements IMessageType, IDeletableMessageType
/**
* @inheritDoc
*/
public function getJavaScriptModuleName()
public function getJavaScriptModuleName(): string
{
return 'Bastelstu.be/Chat/MessageType/Broadcast';
}
@ -55,7 +55,7 @@ final class BroadcastMessageType implements IMessageType, IDeletableMessageType
/**
* @inheritDoc
*/
public function canSee(Message $message, Room $room, ?UserProfile $user = null)
public function canSee(Message $message, Room $room, ?UserProfile $user = null): bool
{
if ($user === null) {
$user = new UserProfile(WCF::getUser());
@ -75,7 +75,7 @@ final class BroadcastMessageType implements IMessageType, IDeletableMessageType
/**
* @inheritDoc
*/
public function canSeeInLog(Message $message, Room $room, ?UserProfile $user = null)
public function canSeeInLog(Message $message, Room $room, ?UserProfile $user = null): bool
{
if ($user === null) {
$user = new UserProfile(WCF::getUser());
@ -95,19 +95,19 @@ final class BroadcastMessageType implements IMessageType, IDeletableMessageType
/**
* @inheritDoc
*/
public function canDelete(Message $message, ?UserProfile $user = null)
public function canDelete(Message $message, ?UserProfile $user = null): bool
{
if ($user === null) {
$user = new UserProfile(WCF::getUser());
}
return $user->getPermission('mod.chat.canDelete');
return !!$user->getPermission('mod.chat.canDelete');
}
/**
* @inheritDoc
*/
public function supportsFastSelect()
public function supportsFastSelect(): bool
{
return false;
}

8
files/lib/system/message/type/ChatUpdateMessageType.class.php
View File

@ -29,7 +29,7 @@ final class ChatUpdateMessageType implements IMessageType
/**
* @inheritDoc
*/
public function getJavaScriptModuleName()
public function getJavaScriptModuleName(): string
{
return 'Bastelstu.be/Chat/MessageType/ChatUpdate';
}
@ -37,7 +37,7 @@ final class ChatUpdateMessageType implements IMessageType
/**
* @inheritDoc
*/
public function canSee(Message $message, Room $room, ?UserProfile $user = null)
public function canSee(Message $message, Room $room, ?UserProfile $user = null): bool
{
return true;
}
@ -45,7 +45,7 @@ final class ChatUpdateMessageType implements IMessageType
/**
* @inheritDoc
*/
public function canSeeInLog(Message $message, Room $room, ?UserProfile $user = null)
public function canSeeInLog(Message $message, Room $room, ?UserProfile $user = null): bool
{
return true;
}
@ -53,7 +53,7 @@ final class ChatUpdateMessageType implements IMessageType
/**
* @inheritDoc
*/
public function supportsFastSelect()
public function supportsFastSelect(): bool
{
return false;
}

8
files/lib/system/message/type/ColorMessageType.class.php
View File

@ -31,7 +31,7 @@ final class ColorMessageType implements IMessageType
/**
* @inheritDoc
*/
public function getJavaScriptModuleName()
public function getJavaScriptModuleName(): string
{
return 'Bastelstu.be/Chat/MessageType/Color';
}
@ -39,7 +39,7 @@ final class ColorMessageType implements IMessageType
/**
* @inheritDoc
*/
public function canSee(Message $message, Room $room, ?UserProfile $user = null)
public function canSee(Message $message, Room $room, ?UserProfile $user = null): bool
{
if ($user === null) {
$user = new UserProfile(WCF::getUser());
@ -59,7 +59,7 @@ final class ColorMessageType implements IMessageType
/**
* @inheritDoc
*/
public function canSeeInLog(Message $message, Room $room, ?UserProfile $user = null)
public function canSeeInLog(Message $message, Room $room, ?UserProfile $user = null): bool
{
return false;
}
@ -67,7 +67,7 @@ final class ColorMessageType implements IMessageType
/**
* @inheritDoc
*/
public function supportsFastSelect()
public function supportsFastSelect(): bool
{
return false;
}

2
files/lib/system/message/type/InfoMessageType.class.php
View File

@ -26,7 +26,7 @@ final class InfoMessageType implements IMessageType
/**
* @inheritDoc
*/
public function getJavaScriptModuleName()
public function getJavaScriptModuleName(): string
{
return 'Bastelstu.be/Chat/MessageType/Info';
}

2
files/lib/system/message/type/JoinMessageType.class.php
View File

@ -26,7 +26,7 @@ final class JoinMessageType implements IMessageType
/**
* @inheritDoc
*/
public function getJavaScriptModuleName()
public function getJavaScriptModuleName(): string
{
return 'Bastelstu.be/Chat/MessageType/Join';
}

2
files/lib/system/message/type/LeaveMessageType.class.php
View File

@ -26,7 +26,7 @@ final class LeaveMessageType implements IMessageType
/**
* @inheritDoc
*/
public function getJavaScriptModuleName()
public function getJavaScriptModuleName(): string
{
return 'Bastelstu.be/Chat/MessageType/Leave';
}

6
files/lib/system/message/type/MeMessageType.class.php
View File

@ -30,7 +30,7 @@ final class MeMessageType implements IMessageType, IDeletableMessageType
/**
* @inheritDoc
*/
public function getJavaScriptModuleName()
public function getJavaScriptModuleName(): string
{
return 'Bastelstu.be/Chat/MessageType/Me';
}
@ -38,12 +38,12 @@ final class MeMessageType implements IMessageType, IDeletableMessageType
/**
* @inheritDoc
*/
public function canDelete(Message $message, ?UserProfile $user = null)
public function canDelete(Message $message, ?UserProfile $user = null): bool
{
if ($user === null) {
$user = new UserProfile(WCF::getUser());
}
return $user->getPermission('mod.chat.canDelete');
return !!$user->getPermission('mod.chat.canDelete');
}
}

6
files/lib/system/message/type/PlainMessageType.class.php
View File

@ -42,7 +42,7 @@ final class PlainMessageType implements IMessageType, IDeletableMessageType
/**
* @inheritDoc
*/
public function getJavaScriptModuleName()
public function getJavaScriptModuleName(): string
{
return 'Bastelstu.be/Chat/MessageType/Plain';
}
@ -50,13 +50,13 @@ final class PlainMessageType implements IMessageType, IDeletableMessageType
/**
* @inheritDoc
*/
public function canDelete(Message $message, ?UserProfile $user = null)
public function canDelete(Message $message, ?UserProfile $user = null): bool
{
if ($user === null) {
$user = new UserProfile(WCF::getUser());
}
return $user->getPermission('mod.chat.canDelete');
return !!$user->getPermission('mod.chat.canDelete');
}
/**

8
files/lib/system/message/type/SuspendMessageType.class.php
View File

@ -29,7 +29,7 @@ final class SuspendMessageType implements IMessageType
/**
* @inheritDoc
*/
public function getJavaScriptModuleName()
public function getJavaScriptModuleName(): string
{
return 'Bastelstu.be/Chat/MessageType/Suspend';
}
@ -59,7 +59,7 @@ final class SuspendMessageType implements IMessageType
/**
* @inheritDoc
*/
public function canSee(Message $message, Room $room, ?UserProfile $user = null)
public function canSee(Message $message, Room $room, ?UserProfile $user = null): bool
{
if ($user === null) {
$user = new UserProfile(WCF::getUser());
@ -79,7 +79,7 @@ final class SuspendMessageType implements IMessageType
/**
* @inheritDoc
*/
public function canSeeInLog(Message $message, Room $room, ?UserProfile $user = null)
public function canSeeInLog(Message $message, Room $room, ?UserProfile $user = null): bool
{
if ($user === null) {
$user = new UserProfile(WCF::getUser());
@ -99,7 +99,7 @@ final class SuspendMessageType implements IMessageType
/**
* @inheritDoc
*/
public function supportsFastSelect()
public function supportsFastSelect(): bool
{
return false;
}

6
files/lib/system/message/type/TCanSeeCreator.class.php
View File

@ -30,7 +30,7 @@ trait TCanSeeCreator
/**
* @see \chat\system\message\type\IMessageType::canSee()
*/
public function canSee(Message $message, Room $room, ?UserProfile $user = null)
public function canSee(Message $message, Room $room, ?UserProfile $user = null): bool
{
if ($user === null) {
$user = new UserProfile(WCF::getUser());
@ -50,7 +50,7 @@ trait TCanSeeCreator
/**
* @see \chat\system\message\type\IMessageType::canSeeInLog()
*/
public function canSeeInLog(Message $message, Room $room, ?UserProfile $user = null)
public function canSeeInLog(Message $message, Room $room, ?UserProfile $user = null): bool
{
if ($user === null) {
$user = new UserProfile(WCF::getUser());
@ -70,7 +70,7 @@ trait TCanSeeCreator
/**
* @see \chat\system\message\type\IMessageType::supportsFastSelect()
*/
public function supportsFastSelect()
public function supportsFastSelect(): bool
{
$parameters = [
'result' => true,

6
files/lib/system/message/type/TCanSeeInSameRoom.class.php
View File

@ -29,7 +29,7 @@ trait TCanSeeInSameRoom
/**
* @see \chat\system\message\type\IMessageType::canSee()
*/
public function canSee(Message $message, Room $room, ?UserProfile $user = null)
public function canSee(Message $message, Room $room, ?UserProfile $user = null): bool
{
if ($user === null) {
$user = new UserProfile(WCF::getUser());
@ -49,7 +49,7 @@ trait TCanSeeInSameRoom
/**
* @see \chat\system\message\type\IMessageType::canSeeInLog()
*/
public function canSeeInLog(Message $message, Room $room, ?UserProfile $user = null)
public function canSeeInLog(Message $message, Room $room, ?UserProfile $user = null): bool
{
if ($user === null) {
$user = new UserProfile(WCF::getUser());
@ -69,7 +69,7 @@ trait TCanSeeInSameRoom
/**
* @see \chat\system\message\type\IMessageType::supportsFastSelect()
*/
public function supportsFastSelect()
public function supportsFastSelect(): bool
{
$parameters = [
'result' => true,

16
files/lib/system/message/type/TeamMessageType.class.php
View File

@ -39,7 +39,7 @@ final class TeamMessageType implements IMessageType, IDeletableMessageType
/**
* @inheritDoc
*/
public function getJavaScriptModuleName()
public function getJavaScriptModuleName(): string
{
return 'Bastelstu.be/Chat/MessageType/Team';
}
@ -55,19 +55,19 @@ final class TeamMessageType implements IMessageType, IDeletableMessageType
/**
* @inheritDoc
*/
public function canDelete(Message $message, ?UserProfile $user = null)
public function canDelete(Message $message, ?UserProfile $user = null): bool
{
if ($user === null) {
$user = new UserProfile(WCF::getUser());
}
return $user->getPermission('mod.chat.canDelete');
return !!$user->getPermission('mod.chat.canDelete');
}
/**
* @inheritDoc
*/
public function canSee(Message $message, Room $room, ?UserProfile $user = null)
public function canSee(Message $message, Room $room, ?UserProfile $user = null): bool
{
if ($user === null) {
$user = new UserProfile(WCF::getUser());
@ -77,7 +77,7 @@ final class TeamMessageType implements IMessageType, IDeletableMessageType
'message' => $message,
'room' => $room,
'user' => $user,
'canSee' => $user->getPermission('mod.chat.canTeam'),
'canSee' => !!$user->getPermission('mod.chat.canTeam'),
];
EventHandler::getInstance()->fireAction($this, 'canSee', $parameters);
@ -87,7 +87,7 @@ final class TeamMessageType implements IMessageType, IDeletableMessageType
/**
* @inheritDoc
*/
public function canSeeInLog(Message $message, Room $room, ?UserProfile $user = null)
public function canSeeInLog(Message $message, Room $room, ?UserProfile $user = null): bool
{
if ($user === null) {
$user = new UserProfile(WCF::getUser());
@ -97,7 +97,7 @@ final class TeamMessageType implements IMessageType, IDeletableMessageType
'message' => $message,
'room' => $room,
'user' => $user,
'canSee' => $user->getPermission('mod.chat.canTeam'),
'canSee' => !!$user->getPermission('mod.chat.canTeam'),
];
EventHandler::getInstance()->fireAction($this, 'canSeeInLog', $parameters);
@ -107,7 +107,7 @@ final class TeamMessageType implements IMessageType, IDeletableMessageType
/**
* @inheritDoc
*/
public function supportsFastSelect()
public function supportsFastSelect(): bool
{
return false;
}

2
files/lib/system/message/type/TemproomCreatedMessageType.class.php
View File

@ -26,7 +26,7 @@ final class TemproomCreatedMessageType implements IMessageType
/**
* @inheritDoc
*/
public function getJavaScriptModuleName()
public function getJavaScriptModuleName(): string
{
return 'Bastelstu.be/Chat/MessageType/TemproomCreated';
}

8
files/lib/system/message/type/TemproomInvitedMessageType.class.php
View File

@ -29,7 +29,7 @@ final class TemproomInvitedMessageType implements IMessageType
/**
* @inheritDoc
*/
public function getJavaScriptModuleName()
public function getJavaScriptModuleName(): string
{
return 'Bastelstu.be/Chat/MessageType/TemproomInvited';
}
@ -64,7 +64,7 @@ final class TemproomInvitedMessageType implements IMessageType
/**
* @inheritDoc
*/
public function canSee(Message $message, Room $room, ?UserProfile $user = null)
public function canSee(Message $message, Room $room, ?UserProfile $user = null): bool
{
if ($user === null) {
$user = new UserProfile(WCF::getUser());
@ -84,7 +84,7 @@ final class TemproomInvitedMessageType implements IMessageType
/**
* @inheritDoc
*/
public function canSeeInLog(Message $message, Room $room, ?UserProfile $user = null)
public function canSeeInLog(Message $message, Room $room, ?UserProfile $user = null): bool
{
if ($user === null) {
$user = new UserProfile(WCF::getUser());
@ -104,7 +104,7 @@ final class TemproomInvitedMessageType implements IMessageType
/**
* @inheritDoc
*/
public function supportsFastSelect()
public function supportsFastSelect(): bool
{
$parameters = [
'result' => false,

8
files/lib/system/message/type/TombstoneMessageType.class.php
View File

@ -31,7 +31,7 @@ final class TombstoneMessageType implements IMessageType
/**
* @inheritDoc
*/
public function getJavaScriptModuleName()
public function getJavaScriptModuleName(): string
{
return 'Bastelstu.be/Chat/MessageType/Tombstone';
}
@ -39,7 +39,7 @@ final class TombstoneMessageType implements IMessageType
/**
* @inheritDoc
*/
public function canSee(Message $message, Room $room, ?UserProfile $user = null)
public function canSee(Message $message, Room $room, ?UserProfile $user = null): bool
{
if ($user === null) {
$user = new UserProfile(WCF::getUser());
@ -59,7 +59,7 @@ final class TombstoneMessageType implements IMessageType
/**
* @inheritDoc
*/
public function canSeeInLog(Message $message, Room $room, ?UserProfile $user = null)
public function canSeeInLog(Message $message, Room $room, ?UserProfile $user = null): bool
{
return false;
}
@ -67,7 +67,7 @@ final class TombstoneMessageType implements IMessageType
/**
* @inheritDoc
*/
public function supportsFastSelect()
public function supportsFastSelect(): bool
{
return false;
}

8
files/lib/system/message/type/UnsuspendMessageType.class.php
View File

@ -29,7 +29,7 @@ final class UnsuspendMessageType implements IMessageType
/**
* @inheritDoc
*/
public function getJavaScriptModuleName()
public function getJavaScriptModuleName(): string
{
return 'Bastelstu.be/Chat/MessageType/Unsuspend';
}
@ -59,7 +59,7 @@ final class UnsuspendMessageType implements IMessageType
/**
* @inheritDoc
*/
public function canSee(Message $message, Room $room, ?UserProfile $user = null)
public function canSee(Message $message, Room $room, ?UserProfile $user = null): bool
{
if ($user === null) {
$user = new UserProfile(WCF::getUser());
@ -79,7 +79,7 @@ final class UnsuspendMessageType implements IMessageType
/**
* @inheritDoc
*/
public function canSeeInLog(Message $message, Room $room, ?UserProfile $user = null)
public function canSeeInLog(Message $message, Room $room, ?UserProfile $user = null): bool
{
if ($user === null) {
$user = new UserProfile(WCF::getUser());
@ -99,7 +99,7 @@ final class UnsuspendMessageType implements IMessageType
/**
* @inheritDoc
*/
public function supportsFastSelect()
public function supportsFastSelect(): bool
{
return false;
}

2
files/lib/system/message/type/WhereMessageType.class.php
View File

@ -31,7 +31,7 @@ final class WhereMessageType implements IMessageType
/**
* @inheritDoc
*/
public function getJavaScriptModuleName()
public function getJavaScriptModuleName(): string
{
return 'Bastelstu.be/Chat/MessageType/Where';
}

8
files/lib/system/message/type/WhisperMessageType.class.php
View File

@ -41,7 +41,7 @@ final class WhisperMessageType implements IMessageType
/**
* @inheritDoc
*/
public function getJavaScriptModuleName()
public function getJavaScriptModuleName(): string
{
return 'Bastelstu.be/Chat/MessageType/Whisper';
}
@ -91,7 +91,7 @@ final class WhisperMessageType implements IMessageType
/**
* @inheritDoc
*/
public function canSee(Message $message, Room $room, ?UserProfile $user = null)
public function canSee(Message $message, Room $room, ?UserProfile $user = null): bool
{
if ($user === null) {
$user = new UserProfile(WCF::getUser());
@ -111,7 +111,7 @@ final class WhisperMessageType implements IMessageType
/**
* @inheritDoc
*/
public function canSeeInLog(Message $message, Room $room, ?UserProfile $user = null)
public function canSeeInLog(Message $message, Room $room, ?UserProfile $user = null): bool
{
if ($user === null) {
$user = new UserProfile(WCF::getUser());
@ -131,7 +131,7 @@ final class WhisperMessageType implements IMessageType
/**
* @inheritDoc
*/
public function supportsFastSelect()
public function supportsFastSelect(): bool
{
$parameters = [
'result' => false,