Max/SameBoy
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Even better hueristics

Browse Source
This commit is contained in:
Lior Halphon 2020-04-25 23:26:17 +03:00
parent d1e3ad7790
commit 110cedeaac
1 changed files with 26 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
Core/gb.c
View File

@ -484,17 +484,37 @@ done:;
// Fix a common wrong MBC error // Fix a common wrong MBC error
if (gb->rom[0x147] == 3) { // MBC1 + RAM + Battery if (gb->rom[0x147] == 3) { // MBC1 + RAM + Battery
if (gb->rom_size >= 33 * 0x4000) { bool needs_fix = false;
for (unsigned i = 32 * 0x4000; i < 33 * 0x4000; i++) { if (gb->rom_size >= 0x21 * 0x4000) {
for (unsigned i = 0x20 * 0x4000; i < 0x21 * 0x4000; i++) {
if (gb->rom[i]) { if (gb->rom[i]) {
gb->rom[0x147] = 0x10; // MBC3 + RTC + RAM + Battery needs_fix = true;
GB_configure_cart(gb);
gb->rom[0x147] = 0x3;
GB_log(gb, "ROM claims to use MBC1 but appears to require MBC3 or 5, assuming MBC3.\n");
break; break;
} }
} }
} }
if (!needs_fix && gb->rom_size >= 0x41 * 0x4000) {
for (unsigned i = 0x40 * 0x4000; i < 0x41 * 0x4000; i++) {
if (gb->rom[i]) {
needs_fix = true;
break;
}
}
}
if (!needs_fix && gb->rom_size >= 0x61 * 0x4000) {
for (unsigned i = 0x60 * 0x4000; i < 0x61 * 0x4000; i++) {
if (gb->rom[i]) {
needs_fix = true;
break;
}
}
}
if (needs_fix) {
gb->rom[0x147] = 0x10; // MBC3 + RTC + RAM + Battery
GB_configure_cart(gb);
gb->rom[0x147] = 0x3;
GB_log(gb, "ROM claims to use MBC1 but appears to require MBC3 or 5, assuming MBC3.\n");
}
} }
if (old_rom) { if (old_rom) {