From 4276549acdf8bbb124b7116a6380bfff1f38499d Mon Sep 17 00:00:00 2001 From: Lior Halphon Date: Fri, 19 Oct 2018 01:02:27 +0300 Subject: [PATCH] Research notes TODOs --- Core/apu.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/Core/apu.c b/Core/apu.c index 82a6516..6041c25 100644 --- a/Core/apu.c +++ b/Core/apu.c @@ -797,6 +797,10 @@ void GB_apu_write(GB_gameboy_t *gb, uint8_t reg, uint8_t value) gb->apu.wave_channel.length_enabled = false; } /* Note that we don't change the sample just yet! This was verified on hardware. */ + /* Todo: The first sample *is not* skipped on the DMG, this is a bug introduced + on the CGB. It appears that the bug was fixed on the AGB, but it's not reflected + by PCM434. */ + /* Todo: Similar issues may apply to the other channels on the DMG/AGB, test, verify and fix if needed */ } /* APU glitch - if length is enabled while the DIV-divider's LSB is 1, tick the length once. */