Max/SameBoy
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Add a TODO

Browse Source
This commit is contained in:
Lior Halphon 2021-01-16 15:31:09 +02:00
parent aa421258b8
commit 8e1e889ce0
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
Core/apu.c
View File

@ -712,6 +712,12 @@ uint8_t GB_apu_read(GB_gameboy_t *gb, uint8_t reg)
static inline uint16_t effective_channel4_counter(GB_gameboy_t *gb) static inline uint16_t effective_channel4_counter(GB_gameboy_t *gb)
{ {
/*
TODO: On revisions older than the CGB-D, this behaves differently when
the counter advanced this exact T-cycle. Also, in these revisions,
it seems that "passive" changes (due to the temporary FF value NR43
has during writes) behave slightly different from non-passive ones.
*/
uint16_t effective_counter = gb->apu.noise_channel.counter; uint16_t effective_counter = gb->apu.noise_channel.counter;
/* Ladies and gentlemen, I present you the holy grail glitch of revision detection! */ /* Ladies and gentlemen, I present you the holy grail glitch of revision detection! */
switch (gb->model) { switch (gb->model) {