Max
/
SameBoy
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Todo cleanup

This commit is contained in:
Lior Halphon 2017-05-27 17:30:12 +03:00
parent f34103473e
commit 9b89d76b3b
3 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
Core/camera.c
View File

@ -137,7 +137,6 @@ void GB_camera_write_register(GB_gameboy_t *gb, uint16_t addr, uint8_t value)
GB_log(gb, "Wrote invalid camera register %02x: %2x\n", addr, value);
return;
}
/* Todo: find out what these registers do */
gb->camera_registers[addr] = value;
}
}

8
Core/display.c
View File

@ -204,9 +204,11 @@ static void display_vblank(GB_gameboy_t *gb)
}
if (!gb->disable_rendering && (!(gb->io_registers[GB_IO_LCDC] & 0x80) || gb->stopped)) {
/* LCD is off, memset screen to white */
/* Todo: use RGB callback */
memset(gb->screen, 0xFF, WIDTH * LINES * 4);
/* LCD is off, set screen to white */
uint32_t white = gb->rgb_encode_callback(gb, 0xFF, 0xFF, 0xFF);
for (unsigned i = 0; i < WIDTH * LINES; i++) {
gb ->screen[i] = white;
}
}
gb->vblank_callback(gb);

3
Core/mbc.c
View File

@ -31,7 +31,6 @@ const GB_cartridge_t GB_cart_defs[256] = {
{ GB_MBC5 , GB_STANDARD_MBC, false, false, false, false}, // 19h MBC5
{ GB_MBC5 , GB_STANDARD_MBC, true , false, false, false}, // 1Ah MBC5+RAM
{ GB_MBC5 , GB_STANDARD_MBC, true , true , false, false}, // 1Bh MBC5+RAM+BATTERY
/* Todo: Rumble supported yet */
{ GB_MBC5 , GB_STANDARD_MBC, false, false, false, true }, // 1Ch MBC5+RUMBLE
{ GB_MBC5 , GB_STANDARD_MBC, true , false, false, true }, // 1Dh MBC5+RUMBLE+RAM
{ GB_MBC5 , GB_STANDARD_MBC, true , true , false, true }, // 1Eh MBC5+RUMBLE+RAM+BATTERY
@ -128,7 +127,7 @@ void GB_configure_cart(GB_gameboy_t *gb)
}
gb->mbc_ram = malloc(gb->mbc_ram_size);
/* Todo: Some games assume unintialized MBC RAM is 0xFF. It this true for all cartridges types?*/
/* Todo: Some games assume unintialized MBC RAM is 0xFF. It this true for all cartridges types? */
memset(gb->mbc_ram, 0xFF, gb->mbc_ram_size);
}