From 3133105fc943439445e4950a5f2c26171da85a48 Mon Sep 17 00:00:00 2001 From: Vicki Pfau Date: Tue, 30 Jan 2024 02:51:32 -0800 Subject: [PATCH] Qt: Pay down a bit of MemoryAccessLogView tech debt --- src/platform/qt/MemoryAccessLogView.cpp | 3 ++- src/platform/qt/MemoryAccessLogView.h | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/platform/qt/MemoryAccessLogView.cpp b/src/platform/qt/MemoryAccessLogView.cpp index 0c9325ed3..5998dd517 100644 --- a/src/platform/qt/MemoryAccessLogView.cpp +++ b/src/platform/qt/MemoryAccessLogView.cpp @@ -8,6 +8,7 @@ #include #include "GBAApp.h" +#include "LogController.h" #include "utils.h" #include "VFileDevice.h" @@ -78,7 +79,7 @@ void MemoryAccessLogView::start() { m_controller->attachDebuggerModule(&m_logger.d); if (!mDebuggerAccessLoggerOpen(&m_logger, vf, flags)) { mDebuggerAccessLoggerDeinit(&m_logger); - // log error + LOG(QT, ERROR) << tr("Failed to open memory log file"); return; } diff --git a/src/platform/qt/MemoryAccessLogView.h b/src/platform/qt/MemoryAccessLogView.h index 896ba5a07..ffe31cc43 100644 --- a/src/platform/qt/MemoryAccessLogView.h +++ b/src/platform/qt/MemoryAccessLogView.h @@ -44,7 +44,7 @@ private: QSet m_watchedRegions; QHash m_regionBoxes; QHash m_regionMapping; - struct mDebuggerAccessLogger m_logger; + struct mDebuggerAccessLogger m_logger{}; bool m_active = false; mDebuggerAccessLogRegionFlags activeFlags() const;