clean up according to PR comments
This commit is contained in:
parent
447054674d
commit
578709254f
@ -38,6 +38,7 @@ struct mLibrary {
|
||||
#define CONSTRAINTS_ROMONLY \
|
||||
"CASE WHEN :useSize THEN roms.size = :size ELSE 1 END AND " \
|
||||
"CASE WHEN :usePlatform THEN roms.platform = :platform ELSE 1 END AND " \
|
||||
"CASE WHEN :useModels THEN roms.models & :models ELSE 1 END AND " \
|
||||
"CASE WHEN :useCrc32 THEN roms.crc32 = :crc32 ELSE 1 END AND " \
|
||||
"CASE WHEN :useMd5 THEN roms.md5 = :md5 ELSE 1 END AND " \
|
||||
"CASE WHEN :useSha1 THEN roms.sha1 = :sha1 ELSE 1 END AND " \
|
||||
@ -115,7 +116,9 @@ static void _bindConstraints(sqlite3_stmt* statement, const struct mLibraryEntry
|
||||
}
|
||||
|
||||
if (constraints->platformModels != M_LIBRARY_MODEL_UNKNOWN) {
|
||||
useIndex = sqlite3_bind_parameter_index(statement, ":useModels");
|
||||
index = sqlite3_bind_parameter_index(statement, ":models");
|
||||
sqlite3_bind_int(statement, useIndex, 1);
|
||||
sqlite3_bind_int(statement, index, constraints->platformModels);
|
||||
}
|
||||
}
|
||||
@ -203,7 +206,7 @@ struct mLibrary* mLibraryLoad(const char* path) {
|
||||
} else if (romsTableVersion < 2) {
|
||||
static const char upgradeRomsTable[] =
|
||||
" ALTER TABLE roms"
|
||||
"\nADD COLUMN models INTEGER NULL";
|
||||
"\n ADD COLUMN models INTEGER NULL";
|
||||
if (sqlite3_exec(library->db, upgradeRomsTable, NULL, NULL, NULL)) {
|
||||
goto error;
|
||||
}
|
||||
|
@ -566,7 +566,7 @@ if(BUILD_SUITE)
|
||||
add_test(platform-qt-${TEST_NAME} test-qt-${TEST_NAME})
|
||||
endforeach()
|
||||
else()
|
||||
message("${QT}Test not found")
|
||||
message(WARNING "${QT}Test not found")
|
||||
endif()
|
||||
endif()
|
||||
|
||||
|
Loading…
x
Reference in New Issue
Block a user