Max/SameBoy
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Research notes TODOs

Browse Source
This commit is contained in:
Lior Halphon 2018-10-19 01:02:27 +03:00
parent 324201f336
commit 4276549acd
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Core/apu.c
View File

@ -797,6 +797,10 @@ void GB_apu_write(GB_gameboy_t *gb, uint8_t reg, uint8_t value)
gb->apu.wave_channel.length_enabled = false; gb->apu.wave_channel.length_enabled = false;
} }
/* Note that we don't change the sample just yet! This was verified on hardware. */ /* Note that we don't change the sample just yet! This was verified on hardware. */
/* Todo: The first sample *is not* skipped on the DMG, this is a bug introduced
on the CGB. It appears that the bug was fixed on the AGB, but it's not reflected
by PCM434. */
/* Todo: Similar issues may apply to the other channels on the DMG/AGB, test, verify and fix if needed */
} }
/* APU glitch - if length is enabled while the DIV-divider's LSB is 1, tick the length once. */ /* APU glitch - if length is enabled while the DIV-divider's LSB is 1, tick the length once. */